Helmet as default express middleware in react-server-cli #812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
gigabo
reviewed
Jan 9, 2017
| @@ -143,7 +143,7 @@ export default (webpackConfig) => { | |||
| In the `.reactserverrc` file add an option for `webpackConfig` that points to that function file and when React Server is setting up Webpack it will call your function with the result of the built in Webpack options, allowing you to make any modifications needed. This may also be specified on the command line with the `--webpack-config=<FILE>` option. | |||
|
|
|||
| ### Use Custom Express Middleware | |||
| Currently the default Express Middlewares used are compression, body-parser, cookie-parser. If you need to setup custom express middleware you can do it with a setup function. | |||
| Currently the default Express Middlewares used are compression, body-parser, cookie-parser, helmet with default configuration. If you need to setup custom express middleware you can do it with a setup function. | |||
There was a problem hiding this comment.
We've got enough of these that maybe we should break them out into a bullet list?
Would also be helpful to link them to the project pages so people who aren't familiar with them (I'd never heard of helmet) can learn more.
|
@feychou Thanks for this. Nice to address so many issues at once! It's unfortunately already diverged from master and has a conflict. Please rebase if you get a chance. |
gigabo
approved these changes
Jan 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses these website issues:
#640
#641
#639
It relies on helmet's default configuration; its overall purpose is to make react-server apps more secure by default.