Add user timings for WebPageTest #748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gigabo
force-pushed
the
interactive-performance-mark
branch
from
45951f7 to
4465da4
Compare
|
Updated to eliminate the change in above-the-fold timing logic. I added a |
gigabo
force-pushed
the
interactive-performance-mark
branch
2 times, most recently
from
dd24486 to
389d92e
Compare
Use the browser's `performance.mark` API.
Add two timings:
- `react-server.wake`
- When the ClientController is instantiated.
- `react-server.renderAboveTheFold`
- When the content above the fold has been re-rendered (visible page is interactive)
- `react-server.renderComplete`
- When the whole page has been re-rendered (fully interactive)
davidalber
approved these changes
Nov 11, 2016
sresant
approved these changes
Nov 11, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the browser's
performance.markAPI.Add two timings:
react-server.wakereact-server.renderAboveTheFoldreact-server.renderComplete