Fix 599: use path.join instead of string concatenation #601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| module.exports = { | ||
| routes: { | ||
| HelloWorld: { | ||
| path: ['/'], | ||
| method: 'get', | ||
| page: './pages/hello-world', | ||
| page: path.join('.', 'pages', 'hello-world'), |
There was a problem hiding this comment.
:squint:
I'm so confused by windows.
I thought forward slashes were actually okay now, but you might receive backslashes from getters?
There was a problem hiding this comment.
So, the error was Module not found: Error: Cannot resolve module '..pageshello-world' in C:\mydev\reactserver__clientTemp. What sticks out to me is that there are no slashes in the error message at all, which makes me think that the / is being interpreted as an escape character. I'm hoping that path.join has the logic to do the right thing.
|
Thanks @doug-wade. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #599