Exclude tests and test code from published package #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roblg
force-pushed
the
fix-npmignore-exclude-tests
branch
from
3ed63fb to
2de4108
Compare
|
Nice! Leaner and meaner! 👍 |
|
I probably should have mentioned that this brings the package.tgz file size down from 1.2MB to 350K. 😹 |
|
I also also should have mentioned that I published a pre-release version of 0.0.24 w/ only this change, and wired up our internal app and all of its dependencies to use it. It was a PITA to plumb that change through everywhere, but once I did, everything started, so I don't think I'm missing anything important. |
|
👍 |
roblg
added a commit
that referenced
this pull request
Mar 3, 2016
Exclude tests and test code from published package
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing up our package.json and .npmignore so that we're not publishing tests + test helpers anymore.
I published a gist with the diff between the old and new packages.
I also noticed while doing this that we were still accidentally publishing a bunch of test files. I filed #44 to address cleaning before publishing.