Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait for CSS to load on client transition #330

Merged
merged 1 commit into from
Jul 1, 2016

Conversation

gigabo
Copy link
Contributor

@gigabo gigabo commented Jul 1, 2016

Don't start writing content into the DOM until external CSS has loaded.

Don't start writing content into the DOM until external CSS has loaded.
@gigabo gigabo added the bug An issue with the system label Jul 1, 2016
@roblg
Copy link
Member

roblg commented Jul 1, 2016

Previously, I think we'd get a flash of unstyled (or broken-styled) content as stuff was being added into the dom and stylesheets were being swapped. Does this fix that?

@gigabo
Copy link
Contributor Author

gigabo commented Jul 1, 2016

Does this fix that?

Yep.

@roblg
Copy link
Member

roblg commented Jul 1, 2016

👍

@gigabo gigabo merged commit 0e3bb5c into redfin:master Jul 1, 2016
davidalber pushed a commit to davidalber/react-server that referenced this pull request Jul 24, 2016
Don't start writing content into the DOM until external CSS has loaded.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue with the system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants