Adding X-Content-Type-Options: nosniff header #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
oh shit I didn't realize the appveyor stuff had snuck out of #304 💩 |
|
I disabled the webhook, but I'm not sure what is to be done about the failing check |
|
@doug-wade do you mean what to be done in general about the failing check? I'm pretty sure I have permissions to merge without it passing. |
| @@ -299,6 +299,9 @@ function writeHeader(req, res, context, start, pageObject) { | |||
| res.type('html'); | |||
| res.set('Transfer-Encoding', 'chunked'); | |||
|
|
|||
| // e.g., http://security.stackexchange.com/a/12916 | |||
| res.set('X-Content-Type-Options', 'nosniff'); | |||
There was a problem hiding this comment.
This misses a case. Will push fix shortly.
roblg
force-pushed
the
add-content-type-options-nosniff
branch
from
2cb04ea to
2c64d3c
Compare
| @@ -199,6 +199,9 @@ function renderPage(req, res, context, start, page) { | |||
|
|
|||
| var timer = logger.timer("lifecycle.individual"); | |||
|
|
|||
| // e.g., http://security.stackexchange.com/a/12916 | |||
There was a problem hiding this comment.
Protects some browsers (Chrome, IE) against MIME sniffing attacks.
^ That would be nice to include in the comment here.
It gives the headline so I know whether I'm interested in following the link.
|
😌 |
Protects some browsers against MIME sniffing attacks. (Does not help Firefox due to: https://bugzilla.mozilla.org/show_bug.cgi?id=471020)
roblg
force-pushed
the
add-content-type-options-nosniff
branch
from
2c64d3c to
ebce502
Compare
|
Thanks @roblg. Added a |
davidalber
pushed a commit
to davidalber/react-server
that referenced
this pull request
Jul 24, 2016
Protects some browsers against MIME sniffing attacks. (Does not help Firefox due to: https://bugzilla.mozilla.org/show_bug.cgi?id=471020)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Protects some browsers (Chrome, IE) against MIME sniffing attacks. (Does not help Firefox
due to: https://bugzilla.mozilla.org/show_bug.cgi?id=471020)
More info: http://security.stackexchange.com/a/12916