-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Omit rootcontainers from counting againt getAboveTheFoldCount #153
Omit rootcontainers from counting againt getAboveTheFoldCount #153
Conversation
<div>Three</div> | ||
<RootElement when={this.data}><div>Four</div></RootElement> | ||
</RootContainer>, | ||
<div>Five</div>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be nice to have some text in the content here that says what the viewer should expect to see if things are working properly.
Uh oh... looks like some of the automated tests are failing. @lidawang - You can run those locally with |
Huhm I'm having some trouble with
It also repros when I try to run |
@lidawang - Sounds like your |
Oh, whoa, just read that again. Looks like it's picking up an Might be easiest to start fresh (in your repo root): for d in `ls -d packages/*/node_modules`; do echo $d; rm -r $d; done
npm run bootstrap
npm test |
Should fix #144! Also added the test page I was using to make sure this worked.