Do Lint Better #1002
Merged
Do Lint Better #1002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # .travis.yml # packages/babel-preset-react-server/package.json # packages/react-server-cli/package.json # packages/react-server-data-bundle-cache/package.json # packages/react-server-examples/package.json
…avis is having problems
…int is the standard. Incorporate the React ESlint rules as well.
… npm audit function will happen in a separate update.
…int is the standard. Incorporate the React ESlint rules as well.
…upgrade-lerna-lint-better
…ues with Acorn. Also...make eslint 4 super super happy happy!
roblg
approved these changes
Apr 24, 2019
Upgrade lerna
|
Since this is a minor infrastructure change and all tests are passing, I'll merge after one approval. |
…int is the standard. Incorporate the React ESlint rules as well.
…ues with Acorn. Also...make eslint 4 super super happy happy!
…upgrade-lerna-lint-better
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses all of #999 and incorporates/relies on changes in #997 and #1001 to be approved/integrated. Things shouldn't be linked together, I know, but it's hard to not do that with the number of changes coming.