Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade lerna #1001

Merged
merged 15 commits into from
Apr 24, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,19 @@
language: node_js
node_js:
- node
- "11"
- "10"
- "9"
- "8"
- "6"
before_install:
- npm install -g 'npm@^6.4.0'
- npm --version
- rm package-lock.json
before_script:
- npm run lint
- npm run build
cache:
npm: true
directories:
- node_modules
- packages/babel-plugin-react-server/node_modules
Expand Down
21 changes: 15 additions & 6 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -58,16 +58,25 @@ lerna run lint
lerna exec -- david u
```

You can also work on a single package by `cd`-ing into that module, and using
normal `npm` scripts
You can no longer work on a single package by `cd`-ing into that module, and using
normal `npm` scripts. This is because of the way lerna hoists commands up to the
root level. When working on a single package, instead run the lerna command with
a scope of that package name.

For example, from the root of the repo:
```
cd packages/generator-react-server
npm i
npm test
lerna run build --scope 'react-server'
lerna run build --scope 'react-server-cli'
lerna run test --scope 'react-server-cli'
```

but you should still run a full monorepo build and test before submitting a pr.
You should always run a full monorepo lint, build, and test before submitting a pr.
```
npm run lint
npm run clean
npm run build
npm run test
```

## Testing

Expand Down
2 changes: 2 additions & 0 deletions MAINTAINING.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@
- Make sure it's `https://registry.npmjs.org/`
- `npm run clean`
- `npm run nuke && npm run bootstrap`
- `npm run lint`
- `npm run build`
- `npm test`
- `export GITHUB_AUTH="..."`
- `npm run changelog >> CHANGELOG.md`
Expand Down
8 changes: 6 additions & 2 deletions lerna.json
Original file line number Diff line number Diff line change
@@ -1,10 +1,14 @@
{
"lerna": "2.0.0-beta.38",
"hoist": true,
"lerna": "3.13.2",
"packages": [
"packages/*"
],
"version": "0.8.1",
"command": {
"bootstrap": {
"hoist": true
}
},
"changelog": {
"repo": "redfin/react-server",
"labels": {
Expand Down
Loading