Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add engines to generator-react-server #317

Closed
doug-wade opened this issue Jun 29, 2016 · 2 comments
Closed

Add engines to generator-react-server #317

doug-wade opened this issue Jun 29, 2016 · 2 comments

Comments

@doug-wade
Copy link
Collaborator

Check out the conversation in gitter, but in general, we wanna warn when a user is using the wrong node version
@Noirbot
Copy link
Contributor

Noirbot commented Jun 30, 2016

What would be the correct version though? >4.2.1?

@doug-wade
Copy link
Collaborator Author

@Noirbot seems like a reasonable place to start. If you were really feeling ambitious, you could test it using something like nave or n

Noirbot pushed a commit to Noirbot/react-server that referenced this issue Jul 18, 2016
Issue redfin#317: Add node version to Package.
5996899
@Noirbot Noirbot mentioned this issue Jul 18, 2016
Merged
doug-wade pushed a commit that referenced this issue Jul 18, 2016
@Noirbot @doug-wade
Issue #317: Add node version to Package. (#354)
c1db419
davidalber pushed a commit to davidalber/react-server that referenced this issue Jul 24, 2016
@Noirbot @davidalber
Issue redfin#317: Add node version to Package. (redfin#354)
d7033ed
doug-wade added a commit to doug-wade/react-server that referenced this issue Aug 17, 2016
@doug-wade
redfin#317 Specify supported node versions for generator-react-server
8f673da
@doug-wade doug-wade mentioned this issue Aug 17, 2016
Merged
doug-wade added a commit that referenced this issue Aug 17, 2016
@doug-wade
Merge pull request #574 from doug-wade/fix-317
8f505a7 
#317 Specify supported node versions for generator-react-server
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Noirbot @doug-wade