Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ReactServerAgent doesn't rehydrate err.response on the client #261

Closed
roblg opened this issue Jun 3, 2016 · 1 comment
Closed

ReactServerAgent doesn't rehydrate err.response on the client #261

roblg opened this issue Jun 3, 2016 · 1 comment
Labels
bug An issue with the system

Comments

@roblg
Copy link
Member

roblg commented Jun 3, 2016

Scenario: data request made by ReactServerAgent receives a non-200 response.

Expected:

  • err object, including err.response is written into the data bundle, and rehydrated in the browser.

Actual:

  • err object, including err.response is written into the data bundle, but is not rehydrated in the browser.
@roblg
Copy link
Member Author

roblg commented Jun 3, 2016

(Will work on PR momentarily)

@gigabo gigabo added the bug An issue with the system label Jun 3, 2016
@gigabo gigabo closed this as completed in 16527f2 Jun 3, 2016
gigabo added a commit that referenced this issue Jun 3, 2016
@gigabo
Merge pull request #263 from roblg/parse-error-response-body
ee23e0e 
Fixed: #261 - error response body needs to be rehydrated
@roblg roblg mentioned this issue Jun 3, 2016
Merged
davidalber pushed a commit to davidalber/react-server that referenced this issue Jul 24, 2016
@roblg @davidalber
Fixed: redfin#261 - error response body needs to be rehydrated
8e663a1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug An issue with the system
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gigabo @roblg