Prevent "when" childProps from clobbering "listen" chlidProps (#677)

redfin · Sep 30, 2016 · cbf8256 · cbf8256
1 parent ece8edf
commit cbf8256
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/packages/react-server/core/components/RootElement.js b/packages/react-server/core/components/RootElement.js
@@ -175,7 +175,9 @@ RootElement.scheduleRender = function(element) {
 		.then(el => el && (rendered = el))
 		.then(() => when)
 		.then(childProps => childProps
-			?React.cloneElement(rendered, {childProps})
+			// merge "when" childProps and "listen" childProps preemptively
+			// to prevent cloneElement shallow merge from clobbering "listen" childProps
+			?React.cloneElement(rendered, {childProps: _.assign({}, rendered.props.childProps || {}, childProps)})
 			:rendered
 		)
 }