Skip to content

Commit

Permalink
Fixed bug in https handling (#568)
Browse files Browse the repository at this point in the history
The default `return startServers()` needs to be wrapped in an `else` block because the first `return` statement was done in a callback (inside `pem.createCertificate`).
  • Loading branch information
CreepGin authored and gigabo committed Aug 16, 2016
1 parent f69b753 commit 6adf661
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions packages/react-server-cli/src/commands/start.js
Original file line number Diff line number Diff line change
Expand Up @@ -66,10 +66,10 @@ export default function start(options){
// in this case, we assume that httpOptions is an object that can be passed
// in to https.createServer as options.
return startServers(httpsOptions);
} else {
// Default. Use http.
return startServers();
}

// Default. Use http.
return startServers();
}

// given the server routes file and a port, start a react-server HTML server at
Expand Down

0 comments on commit 6adf661

Please sign in to comment.