Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require sentry-sdk>=1.40.6 #1042

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Require sentry-sdk>=1.40.6 #1042

merged 1 commit into from
Dec 6, 2024

Conversation

chriskuehl
Copy link
Member

sentry-sdk 1.40.6 contains:

Fix compatibility with greenlet/gevent (#2756) by @sentrivana

@salomon-smekecohen found that this improves performance significantly for Baseplate services, so let's bump up our minimum version to help push users to upgrade.

@chriskuehl chriskuehl marked this pull request as ready for review December 4, 2024 16:34
@chriskuehl chriskuehl requested a review from a team as a code owner December 4, 2024 16:34
Copy link
Contributor

@mathyourlife-reddit mathyourlife-reddit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@salomon-smekecohen
Copy link
Contributor

Np! I dont know what minimal version introduced the problem, so this might not help much 😅 but I agree its a good idea to require.

@chriskuehl chriskuehl merged commit 1f7c1de into develop Dec 6, 2024
4 checks passed
@chriskuehl chriskuehl deleted the require-newer-sentry-sdk branch December 6, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants