Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docker tag of ledr sensor to current version 1.6.0-21823 #6

Merged
merged 3 commits into from
Nov 14, 2023

Conversation

rc-vbundage
Copy link
Contributor

@rc-vbundage rc-vbundage commented Nov 13, 2023

Description

  • Updates the appVersion of the chart to use use the 1.6.0-21823 docker tag which is the current latest sensor version
  • Updates the chart-testing action as there was a fix for an issue applied in 2.5.0

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Unable to run chart testing on my local Rancher K3s cluster atm but it did pass in CI.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@rc-vbundage rc-vbundage marked this pull request as ready for review November 14, 2023 00:22
@rc-vbundage rc-vbundage requested a review from a team as a code owner November 14, 2023 00:22
Copy link
Contributor

@3k9CP3bu4MoP 3k9CP3bu4MoP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for digging into the chart-testing error when it popped up!

@rc-vbundage rc-vbundage merged commit b53a163 into main Nov 14, 2023
2 checks passed
@rc-vbundage rc-vbundage deleted the update-ledr-sensor-1.6.0 branch November 14, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants