Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delay persists between lines of dialogue. #5

Closed
JonathanGorr opened this issue Feb 28, 2017 · 5 comments
Closed

Delay persists between lines of dialogue. #5

JonathanGorr opened this issue Feb 28, 2017 · 5 comments

Comments

@JonathanGorr
Copy link

JonathanGorr commented Feb 28, 2017 •
edited
Loading

The text typer doesn't reset the text speed on a new line. The bug occurs when you skip dialogue between delay tags. I fixed this temporarily by prefacing each new line with its own delay:

scripts.Enqueue("<delay=0></delay>" + conversationText);
@edwardrowe
Copy link

I'm at GDC this week so I'm likely not going to be able to look at this until next week. Thanks for the bug report, though.

I'm having a bit of trouble understanding quite what the bug is. Every opening delay tag should require a closing tag within the printing text. What do the calls the bugged calls that you are making to a TextTyper component look like?

@edwardrowe
Copy link

Ah I see what you mean now. If you skip or print new text while the Delay tag is active in the print, it will not restore the delay.

edwardrowe added a commit that referenced this issue Mar 9, 2017
@edwardrowe
Cleanup state in TextTyper printing (issue #2)
3cba8b0 
This adds a TypedTextGenerator that provides a pure function to return
the print string at a desired place in a line of dialogue. This
resolves some of the issues I had with mishandled state, namely
issue #7 and issue #5.
@edwardrowe
Copy link

Should be fixed in latest release (v1.2). You may need to delete the old plugin before installing the new one. Unity doesn't seem to like when files are renamed...

@JonathanGorr
Copy link
Author

Sorry buddy. I don't get email notifications apparently for github. I was at GDC too funnily enough. Thanks for fixing it. Great plugin!

@edwardrowe
Copy link

No problem! Thanks for the bug report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@edwardrowe @JonathanGorr