Opravy drobných chyb #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dosty85
reviewed
Sep 3, 2018
| @@ -37,7 +37,7 @@ function check_access(){ | |||
| if($post_groups && !$this->user_can_view_post() && !is_home() && !is_front_page()){ | |||
| $no_access_url = $this->get_no_access_redirect_url(); | |||
|
|
|||
| $url = $no_access_url ? $no_access_url : site_url(); | |||
| $url = $no_access_url ?: site_url(); | |||
There was a problem hiding this comment.
Nejsem si jist, ze toto v php 5.3 projde.
| @@ -98,7 +99,7 @@ public function create_item($request){ | |||
|
|
|||
| // Set the membership valid_to param | |||
| $membership = new SSC_Membership($user_id); | |||
| $valid_to = $request->get_param('valid_to') ? $request->get_param('valid_to') : ''; | |||
| $valid_to = $request->get_param('valid_to') ?: ''; | |||
There was a problem hiding this comment.
Nejsem si jist, ze toto v php 5.3 projde.
|
Ano, to mám ověřené, |
|
Ale projde i kdyz tam neni promenna? Podminka ? true : false; Projde, ale
myslim ze s timto je v 5.3 problem:
Podminka ? true;
Podminka ? : false;
Dne po 3. zář 2018 6:35 uživatel Jakub Bouček <[email protected]>
napsal:
… Ano, to mám ověřené, short ternary je od 5.3:
https://secure.php.net/manual/en/language.operators.comparison.php#language.operators.comparison.ternary
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#6 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ATtKn34jJp5rCKYjrbTI0uNNzEM2_dojks5uXLGZgaJpZM4WW3hZ>
.
|
|
Ano :) Ternary operator je: conditions ? true : false`Short ternary operator je právě to zkrácené: conditions ?: false` |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opravy zjevných chyb
BC break: Ne