forked from rook/rook
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Syncing latest changes from upstream master for rook #741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given that Ceph Quincy (v17) is past end of life, remove Quincy from the supported Ceph versions, examples, and documentation. Supported versions now include only Reef and Squid. Signed-off-by: Travis Nielsen <[email protected]>
Added these functions for running commands in the toolbox pod: - toolbox() - ceph() - rbd() - radosgw-admin() Signed-off-by: Joshua Hoblitt <[email protected]>
When attempting to use pre-existing (or cephBlockPool managed) pools and the cephObjectStore.spec.{metadataPool,dataPool} fields are not specified, rgw creation will fail with this error: 2024-09-25 21:00:17.744358 E | ceph-object-controller: failed to reconcile CephObjectStore "rook-ceph/test1". failed to create object store deployments: failed to create object pools: failed to create metadata pools: failed to create pool "test1.rgw.control": pool "test1.rgw.control" type is not defined as replicated or erasure coded Signed-off-by: Joshua Hoblitt <[email protected]>
Signed-off-by: Joshua Hoblitt <[email protected]>
Factor out most of the CRs used by various canary tests to a new deploy_cluster_full_of_cruft_please_stop_using_this() function. Signed-off-by: Joshua Hoblitt <[email protected]>
This allows all functions to be called in any order without concern for the CWD. Signed-off-by: Joshua Hoblitt <[email protected]>
…isting-pools rgw: fix CephObjectStore failing with pre-existing pools
These fields must be optional in order to allow usage of pre-existing pools managed by CephBlockPool CR(s). Signed-off-by: Joshua Hoblitt <[email protected]>
core: Remove support for Ceph Quincy
…g-pools rgw: fix CephObjectZone failing with pre-existing pools
df-build-team
force-pushed
the
sync_us--master
branch
from
October 5, 2024 08:04
ed4b275
to
611e47e
Compare
…-master Signed-off-by: Ceph Jenkins <[email protected]>
add generated csv changes Signed-off-by: Ceph Jenkins <[email protected]>
df-build-team
force-pushed
the
sync_us--master
branch
from
October 7, 2024 05:06
611e47e
to
1585652
Compare
subhamkrai
approved these changes
Oct 7, 2024
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: df-build-team, subhamkrai The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR containing the latest commits from upstream master branch