Syncing latest changes from master for rook #724
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only single pool will get created if there are multiple data pool entries with same name. This PR just adds a check to fail if duplicate pools are present. Signed-off-by: sp98 <[email protected]>
This reworks the docs-check ci workflow in several ways: * It renames the make target 'check-docs' to the more systematic 'check.docs'. * It adds a 'docs'mode to the files validation script, and uses the script in `make check.docs`. Overall, the workflow and local make targets are more systematic and consistent with this change. Signed-off-by: Michael Adam <[email protected]>
Signed-off-by: Artem Torubarov <[email protected]>
we have 3.12.2 as the new cephcsi release updating the rook to use the same. Signed-off-by: Madhu Rajanna <[email protected]>
csi: update to new cephcsi release
ci: slightly rework the docs-check workflow.
This makes the naming of ci-related make targets more systematic and consistent. It is based on PR rook#14672 and continues the pattern started in that PR. Signed-off-by: Michael Adam <[email protected]>
to keep it simple we'll not delete the csi-operator resources we'll only document this for users who want to switch to csi-drivers. Anyways by next release we'll only support csi-operator only. Signed-off-by: subhamkrai <[email protected]>
CI: rename target check-helm-docs to check.helm-docs
Bumps the github-dependencies group with 2 updates: [github.com/prometheus-operator/prometheus-operator/pkg/apis/monitoring](https://github.com/prometheus-operator/prometheus-operator) and [github.com/prometheus-operator/prometheus-operator/pkg/client](https://github.com/prometheus-operator/prometheus-operator). Updates `github.com/prometheus-operator/prometheus-operator/pkg/apis/monitoring` from 0.76.0 to 0.76.1 - [Release notes](https://github.com/prometheus-operator/prometheus-operator/releases) - [Changelog](https://github.com/prometheus-operator/prometheus-operator/blob/main/CHANGELOG.md) - [Commits](prometheus-operator/prometheus-operator@v0.76.0...v0.76.1) Updates `github.com/prometheus-operator/prometheus-operator/pkg/client` from 0.76.0 to 0.76.1 - [Release notes](https://github.com/prometheus-operator/prometheus-operator/releases) - [Changelog](https://github.com/prometheus-operator/prometheus-operator/blob/main/CHANGELOG.md) - [Commits](prometheus-operator/prometheus-operator@v0.76.0...v0.76.1) --- updated-dependencies: - dependency-name: github.com/prometheus-operator/prometheus-operator/pkg/apis/monitoring dependency-type: direct:production update-type: version-update:semver-patch dependency-group: github-dependencies - dependency-name: github.com/prometheus-operator/prometheus-operator/pkg/client dependency-type: direct:production update-type: version-update:semver-patch dependency-group: github-dependencies ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [wagoid/commitlint-github-action](https://github.com/wagoid/commitlint-github-action) from 6.1.1 to 6.1.2. - [Changelog](https://github.com/wagoid/commitlint-github-action/blob/master/CHANGELOG.md) - [Commits](wagoid/commitlint-github-action@a2bc521...3d28780) --- updated-dependencies: - dependency-name: wagoid/commitlint-github-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [snyk/actions](https://github.com/snyk/actions) from 9213221444c2dc9e8b2502c1e857c26d851e84a7 to cdb760004ba9ea4d525f2e043745dfe85bb9077e. - [Release notes](https://github.com/snyk/actions/releases) - [Commits](snyk/actions@9213221...cdb7600) --- updated-dependencies: - dependency-name: snyk/actions dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
core: check for duplicate ceph fs pool names
csi: stop deleting csi-operator resources
Rgw pool placement
…oid/commitlint-github-action-6.1.2 build(deps): bump wagoid/commitlint-github-action from 6.1.1 to 6.1.2
…k/actions-cdb760004ba9ea4d525f2e043745dfe85bb9077e build(deps): bump snyk/actions from 9213221444c2dc9e8b2502c1e857c26d851e84a7 to cdb760004ba9ea4d525f2e043745dfe85bb9077e
…dependencies-cade2347bc build(deps): bump the github-dependencies group with 2 updates
The crush rules may have a negative step num. Rook had assumed negative values were not possible, but just had not been encountered previously in a custom crush rule. Signed-off-by: Travis Nielsen <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: df-build-team The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Add missing csi addon's feature in the Rook document Signed-off-by: parth-gr <[email protected]>
pool: Allow negative step num in crush rule
doc: add the pv encryption key rotation job
When pool placements were recently added to the object store CRD, it seems that codegen didn't get run, and Rook's CI didn't accurately catch the codegen issue. This will address adding the missing generated code. Follow-up work will address fixing CI so that it doesn't continue missing when codegen needs to be run. Signed-off-by: Blaine Gardner <[email protected]>
object: add missing codegen from pool placements
Co-authored-by: Travis Nielsen <[email protected]> Signed-off-by: Alexander Trost <[email protected]>
Signed-off-by: Alexander Trost <[email protected]>
docs: add grafana dashboards files to docs
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.26.6 to 3.26.7. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@4dd1613...8214744) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
csi: fix the ROOK_CSI_DISABLE_DRIVER flag in the csi reconcile
build: support golang 1.23
The cephConfig settings in the CephCluster CR have been stable and there are no planned changes, so remove the experimental documentation indicator. Also, clarify the usage and the precedence of the ceph config options. Signed-off-by: Travis Nielsen <[email protected]>
let's keep specific z version in go.mod 1.22.5. Signed-off-by: subhamkrai <[email protected]>
build: keep specific z version in go mod 1.22.5
default application name is updated inside the `CreatePool` method. Send pool spec as address in order to preserve this change. Signed-off-by: Santosh Pillai <[email protected]>
openshift-merge-robot
removed
the
needs-rebase
Bumps [go.uber.org/automaxprocs](https://github.com/uber-go/automaxprocs) from 1.5.3 to 1.6.0. - [Release notes](https://github.com/uber-go/automaxprocs/releases) - [Changelog](https://github.com/uber-go/automaxprocs/blob/master/CHANGELOG.md) - [Commits](uber-go/automaxprocs@v1.5.3...v1.6.0) --- updated-dependencies: - dependency-name: go.uber.org/automaxprocs dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [actions/checkout](https://github.com/actions/checkout) from 4.1.7 to 4.2.0. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@692973e...d632683) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.26.8 to 3.26.9. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@294a9d9...461ef6c) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
deployments on openshift where we need csi container pods to be run on privileged, the logrotate sidecar container was missing the privileged permission letting, side car to not run properly Signed-off-by: parth-gr <[email protected]>
…ions/checkout-4.2.0 build(deps): bump actions/checkout from 4.1.7 to 4.2.0
…hub/codeql-action-3.26.9 build(deps): bump github/codeql-action from 3.26.8 to 3.26.9
….org/automaxprocs-1.6.0 build(deps): bump go.uber.org/automaxprocs from 1.5.3 to 1.6.0
docs: Declare cephconfig settings stable
csi: add sc privileged to logrotate sidecar container
core: preserve pool application name change
Fix OSD isn't up. As sdb device might change to vdb in the runner, let find_extra_block_dev() exclude the nbd devices and find the proper extra device for OSD. Clean up the nbd devices after the test job is running. Fix logs artifact upload twice and collect logs before clean up. Signed-off-by: Xinliang Liu <[email protected]>
ci: fix canary-arm64 job
This adds an operator config setting ROOK_REVISION_HISTORY_LIMIT defaulting to kubernetes'value for RevisionHistoryLimit. If configured, the provided value will be used as RevisionHistoryLimit for all Deployments rook creates. Fixes: rook#12722 Signed-off-by: Michael Adam <[email protected]>
Co-authored-by: Travis Nielsen <[email protected]> Signed-off-by: Michael Adam <[email protected]>
core: add ROOK_REVISION_HISTORY_LIMIT operator setting
The ROOK_ENFORCE_HOST_NETWORK option was implemented recently and now we add the helm setting to expose this new setting in the rook chart. Signed-off-by: Travis Nielsen <[email protected]>
helm: Add enforce host network setting
df-build-team
force-pushed
the
sync_ds--master
branch
from
f7cb8a2
to
fd3927b
Compare
openshift-merge-robot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR containing the latest commits from master branch