Bug 2245978: multus: use rook image for ip range detection

[BlaineEXE]

Use the Rook image (defined by the operator pod) to detect the Multus network address ranges. It is reasonable for users to want to have a minimal Ceph image that does not have the ip utility installed, which is used for detecting the address ranges of multus interfaces. Instead, use the Rook image, which Rook can ensure has the ip tool if Ceph ever removes it from their image.

Signed-off-by: Blaine Gardner [email protected]
(cherry picked from commit 8aec30a)

Description of your changes:

Which issue is resolved by this Pull Request:
Resolves #

Checklist:

• Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide).
• Skip Tests for Docs: If this is only a documentation change, add the label skip-ci on the PR.
• Reviewed the developer guide on Submitting a Pull Request
• Pending release notes updated with breaking and/or notable changes for the next minor release.
• Documentation has been updated, if necessary.
• Unit tests have been added, if necessary.
• Integration tests have been added, if necessary.

[openshift-ci]

@BlaineEXE: This pull request references Bugzilla bug 2245978, which is invalid:

• expected the bug to target the "ODF 4.14.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2245978: multus: use rook image for ip range detection

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[travisn]

Looks good, assuming we get the ip tool in the base image downstream.
/lgtm
/approve

[BlaineEXE]

Correction @travisn: This PR means that ODF needs to get the ip tool into the Rook image, and would make it so we do not need it in the base (RHCS) image. Unless I'm misunderstanding the base image used for ODF-Rook.

[travisn]

Correction @travisn: This PR means that ODF needs to get the ip tool into the Rook image, and would make it so we do not need it in the base (RHCS) image. Unless I'm misunderstanding the base image used for ODF-Rook.

Oh right, in the downstream rook image is what I meant, thanks.

[travisn]

What if we also cherry-pick some recent CI fixes with this?
rook#13128
rook#13057
rook#13105

[BlaineEXE]

What if we also cherry-pick some recent CI fixes with this? rook#13128 rook#13057 rook#13105

Done. Each is a separate cherry-pick commit.

[travisn]

/lgtm
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: BlaineEXE, travisn

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[travisn]

/bugzilla refresh

[openshift-ci]

@travisn: This pull request references Bugzilla bug 2245978, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (ODF 4.14.0) matches configured target release for branch (ODF 4.14.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @nehaberry

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@openshift-ci[bot]: GitHub didn't allow me to request PR reviews from the following users: nehaberry.

Note that only red-hat-storage members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@travisn: This pull request references Bugzilla bug 2245978, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (ODF 4.14.0) matches configured target release for branch (ODF 4.14.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @nehaberry

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@BlaineEXE: All pull requests linked via external trackers have merged:

• red-hat-storage/rook#533

Bugzilla bug 2245978 has been moved to the MODIFIED state.

In response to this:

Bug 2245978: multus: use rook image for ip range detection

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.