Bug 2236444: monitoring: set port for servicemonitor for ceph-exporter #516
Conversation
|
@weirdwiz: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: weirdwiz The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
weirdwiz
changed the title
openshift-ci
bot
added
bugzilla/severity-urgent
|
@weirdwiz: This pull request references Bugzilla bug 2236444, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@weirdwiz is this already fixed in the upstream project? we first need to fix it rook/rook upstream project and then we cherry-pick. |
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
ceph-exporter's ServiceMonitor and Service CRD contain different port name, which results in no metrics being collected by prometheus. this commit makes GetCephMonitor configurable, which we use to set consistent port names in ServiceMonitor and Service for ceph-exporter. Signed-off-by: Divyansh Kamboj <[email protected]>
weirdwiz
force-pushed
the
rename-service
branch
from
f5b2139
to
db10c33
Compare
weirdwiz
changed the title
|
@subhamkrai updated the commit for the chery-pick |
|
@travisn ^^ |
|
/unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/bugzilla refresh |
|
@subhamkrai: This pull request references Bugzilla bug 2236444, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@weirdwiz: All pull requests linked via external trackers have merged: Bugzilla bug 2236444 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This commit makes the port name configurable to set the port name of the service monitor.