Bug 2246638: DRCluster does not clear its condition after it is unfenced #295
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem:
When a drcluster is fenced or unfenced and the operation is complete, ramen hub operator doesn't delete the manifestwork that it created to perform the operation. The manifestwork is therefore left to be reused for further operations on the same drcluster. When reused in such a manner, it is possible that the result condition from the previous operation is referred to by Ramen as the current state. This leads to a potential data corruption bug where Ramen allows for deployment of the apps on the failover cluster before the failed cluster is completely fenced.
The solution:
NF manifest work is not deleted after every unfence operation.