Bug 2308101: logrotate: add logrotate functionality for csi operator #190
Conversation
|
@parth-gr: This pull request references Bugzilla bug 2308101, which is valid. No validations were run on this bugRequesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@openshift-ci[bot]: GitHub didn't allow me to request PR reviews from the following users: PrasadDesala. Note that only red-hat-storage members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherry-pick 4.17 |
|
@parth-gr: once the present PR merges, I will cherry-pick it on top of 4.17 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@parth-gr: GitHub didn't allow me to assign the following users: Madhu-1. Note that only red-hat-storage members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. |
collection-scripts/gather_ceph_logs
Outdated
| dbglog "collecting csi logs from node ${node}" | ||
| oc rsync -n "${ns}" "$(oc get pods -n "${ns}" --no-headers | grep "${node//./}-debug" | awk '{print $1}')":/host/var/lib/cephcsi/"${ns}".rbd.csi.ceph.com-ctrlplugin "${CSI_LOG_OUTPUT_DIR}" | ||
| oc rsync -n "${ns}" "$(oc get pods -n "${ns}" --no-headers | grep "${node//./}-debug" | awk '{print $1}')":/host/var/lib/cephcsi/"${ns}".rbd.csi.ceph.com-nodeplugin "${CSI_LOG_OUTPUT_DIR}" | ||
| oc rsync -n "${ns}" "$(oc get pods -n "${ns}" --no-headers | grep "${node//./}-debug" | awk '{print $1}')":/host/var/lib/cephcsi/"${ns}".cephfs.csi.ceph.com-ctrlplugin "${CSI_LOG_OUTPUT_DIR}" |
There was a problem hiding this comment.
@yati1998 if the required host path is not present var/lib/cephcsi/"${ns}".cephfs.csi.ceph.com-ctrlplugin , the other must gather collection wont fail, right?
There was a problem hiding this comment.
no it wont. Did you test the changes?
There was a problem hiding this comment.
Can we add a check below before calling the function, to make sure we collect it incase of csi-operator only?
There was a problem hiding this comment.
Did you test the changes?
Can you help me doing it, i am not sure on the steps,
Can we add a check below before calling the function, to make sure we collect it incase of csi-operator only?
Actually even if its csi operator there might be case that nfs driver is disabled then dont collect nfs,
So if the current case is working as expected there is no need for seprate checks
There was a problem hiding this comment.
sure, we can discuss this offline
currently client operator has started using csi operator so collecting the csi logs from a new host path hat csi-operator supports Signed-off-by: parth-gr <[email protected]>
parth-gr
force-pushed
the
logrotate-client
branch
from
5cd19bb
to
799c77a
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: parth-gr, yati1998 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 491aef5
into
red-hat-storage:main
|
@parth-gr: cannot checkout In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@yati1998 Where is this function The changes only define the function but never call it. |
Ohh , will add a commit, Thanks for catching |
it is called in earlier PR made by him right? |
|
okay, it's just csi_log_collection, okay my bad!! |
|
/cherry-pick release-4.17 |
|
@parth-gr: new pull request created: #192 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
currently client operator has started using csi operator so collecting the csi logs from a new host path
hat csi-operator supports