Update ImagePullPolicy to Always #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR updates the ImagePullPolicy for the must-gather pod to Always. This adds value to the development phase where one can just delete the pod and have an updated one with the latest image. Prior to this one had to use different tags for each test which was not ideal. Note: This would not increase pod deploy timinigs in prod env as we do not update the prod image that often and ImagePullPolicy of always first checks the SHA sum from registry against local cache. If the image is cached locally, it is not pulled again. Signed-off-by: Niraj Yadav <[email protected]>
|
can you please check the CI failure. @black-dragon74 |
It is unrelated to must-gather. The CI is unable to pull images from registry. |
|
/retest |
1 similar comment
|
/retest |
yati1998
approved these changes
Aug 16, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: black-dragon74, yati1998 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit f4cff39
into
red-hat-storage:main
5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the ImagePullPolicy for the must-gather pod to Always.
This adds value to the development phase where one can just delete the pod and have an updated one with the latest image.
Prior to this one had to use different tags for each test which was not ideal.
Note: This would not increase pod deploy timinigs in prod env as we do not update the prod image that often and ImagePullPolicy of always first checks the SHA sum from registry against local cache.
If the image is cached locally, it is not pulled again.