csi: add logrotate file to a csi log dir #179
Conversation
| ceph_daemon_log_collection() { | ||
| dbglog "collecting csi and ceph daemon logs from node ${node}" | ||
| # as per the correction we are keeping both /var/lib/rook & /var/log/ceph for ceph pods, as to not break anything | ||
| oc rsync -n "${ns}" "$(oc get pods -n "${ns}" --no-headers | grep "${node//./}-debug" | awk '{print $1}')":/host/var/log/ceph/ "${CEPH_DAEMON_LOG_OUTPUT_DIR}" |
There was a problem hiding this comment.
once the csi operator changes are done we need to add the query the driver and get the host path here.
There was a problem hiding this comment.
ceph daemon logs are collected above right?
There was a problem hiding this comment.
The path is incorrect /var/lib/rook which should be /var/log/ceph
As discussed offline already we will keep both as not break anything
There was a problem hiding this comment.
This is resolved then, right?
There was a problem hiding this comment.
Yes correct, will have a follow up PR once CSI-operator is there,
Till now it works with Rook operator
parth-gr
force-pushed
the
logrotate-files
branch
2 times, most recently
from
6eda225
to
17657d5
Compare
added the csi log to a csi log directory csi_log_${node}
Also updated correct dir path to cllect the ceph daemon logs
closes: red-hat-storage#178
Signed-off-by: parth-gr <[email protected]>
parth-gr
force-pushed
the
logrotate-files
branch
from
17657d5
to
702a614
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: black-dragon74, parth-gr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 4dbaecf
into
red-hat-storage:main
added the csi log to a csi log directory csi_log_${node}
Also updated correct dir path to cllect the ceph daemon logs
closes: #178