pass the BASE_COLLECTION_PATH for odf collection

[yati1998]

odf flag fails to collect proper logs in case
of radosnamespace due to absence of
BASE_COLLECTION_PATH.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yati1998

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [yati1998]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[yati1998]

/cherry-pick release-4.16

[openshift-cherrypick-robot]

@yati1998: new pull request created: #175

In response to this:

/cherry-pick release-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[black-dragon74]

Did you verify this? Simply passing the arg would do nothing as we never read it. And passing it as an arg doesn't export it.

However, since all the scripts work fine, this needs further investigation.

[yati1998]

Did you verify this? Simply passing the arg would do nothing as we never read it. And passing it as an arg doesn't export it.
yes this has been verified
However, since all the scripts work fine, this needs further investigation.
after introducing internal functions in gather_ceph_resources, we need to pass the argument so that it can consider the argument number in proper order. Without passing the argument, it is failing to collect the logs with odf flag, while it is working fine with the ceph flag.

[black-dragon74]

after introducing internal functions in gather_ceph_resources, we need to pass the argument so that it can consider the argument number in proper order. Without passing the argument, it is failing to collect the logs with odf flag, while it is working fine with the ceph flag.

I see only one instance where we depend on positional args, that is inside collect_info, the arg we pass is of no use here.

I see you noticed it is fine when using -c but errors out only when -o is used. Seems rather strange to me as we are calling the same script in both of the cases and -c doesn't even pass the BASE_COLLECTION_PATH to the subscript.

Do you recall the error that was encountered. I am intrigued as this should not happen. We are missing something else.

Regards

[yati1998]

I see you noticed it is fine when using -c but errors out only when -o is used. Seems rather strange to me as we are calling the same script in both of the cases and -c doesn't even pass the BASE_COLLECTION_PATH to the subscript.

Do you recall the error that was encountered. I am intrigued as this should not happen. We are missing something else.

There is no error, but without passing the BASE_COLLECTION_PATH , the radosnamespace is not getting collected, probably the internal function is not working in that.

Yeah this is bit strange as it's running the same script, but this is the only loophole I can see.
Let's discuss on this offline.
For now I see all the required logs getting collected.