Bug 2297447: Use ManagedClusterView for ODF info - DRPolicy creation #1470
Conversation
|
/hold |
packages/mco/components/create-dr-policy/select-cluster-list.tsx
Outdated
Show resolved
Hide resolved
packages/mco/components/create-dr-policy/select-cluster-list.tsx
Outdated
Show resolved
Hide resolved
|
remove clusterclaim checks from DRPolicy creation unit tests... |
packages/mco/components/create-dr-policy/select-cluster-list.tsx
Outdated
Show resolved
Hide resolved
packages/mco/components/create-dr-policy/select-cluster-list.tsx
Outdated
Show resolved
Hide resolved
packages/mco/components/create-dr-policy/select-cluster-list.tsx
Outdated
Show resolved
Hide resolved
packages/mco/components/create-dr-policy/select-cluster-list.tsx
Outdated
Show resolved
Hide resolved
packages/mco/components/create-dr-policy/select-cluster-list.tsx
Outdated
Show resolved
Hide resolved
packages/mco/components/create-dr-policy/select-cluster-list.tsx
Outdated
Show resolved
Hide resolved
packages/mco/components/create-dr-policy/select-cluster-list.tsx
Outdated
Show resolved
Hide resolved
SanjalKatiyar
force-pushed
the
managed_cluster_config
branch
from
a7a3fc1
to
28f357d
Compare
SanjalKatiyar
force-pushed
the
managed_cluster_config
branch
from
28f357d
to
361628a
Compare
|
/hold cancel |
|
/retitle Bug 2297447: Use ManagedClusterView for ODF info - DRPolicy creation |
openshift-ci
bot
changed the title
|
@SanjalKatiyar: This pull request references Bugzilla bug 2297447, which is valid. No validations were run on this bugRequesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@openshift-ci[bot]: GitHub didn't allow me to request PR reviews from the following users: PrasadDesala. Note that only red-hat-storage members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
| export const MCV_NAME_TEMPLATE = 'odf-multicluster-mcv-'; | ||
|
|
||
| export const MCO_CREATED_BY_LABEL_KEY = | ||
| 'multicluster.odf.openshift.io/created-by'; | ||
| export const MCO_CREATED_BY_MC_CONTROLLER = | ||
| 'odf-multicluster-managedcluster-controller'; |
There was a problem hiding this comment.
@vbnrh can u cross-verify these constants ?? also, plz make sure these are not changed/updated on the MCO side by mistake.
SanjalKatiyar
force-pushed
the
managed_cluster_config
branch
from
361628a
to
5b21ef6
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SanjalKatiyar, vbnrh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 654ccd9
into
red-hat-storage:master
https://bugzilla.redhat.com/show_bug.cgi?id=2297447
Before:
OCS used to create multiple ClusterClaims and MCO console used to read ODF info (StorageCluster, Ceph details) from ManageCluster CR's status.
After:
red-hat-storage/ocs-operator#2440
red-hat-storage/odf-multicluster-orchestrator#219
OCS now creates a single ConfigMap (with all the StorageClusters, Clients details) and a single ClusterClaim (with ConfigMap's namespaced-name details), MCO creates the corresponding ManagedClusterView referencing this ConfigMap and MCO console reads ODF info from the ManagedClusterView CR.