controllers: send storage utilization ratio in heartbeat #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rchikatw
commented
Oct 9, 2024
•
rchikatw
commented
- send storage utilization ratio in a heartbeat
- This will be calculated from a CRQ resource
- This field will be used to show the storage utilization of the client in the provider mode dashboard
- go.mod file changes was added by taking this PR into account: Adding StorageQuotaUtilizationRatio field for storage consumer api ocs-operator#2697
rchikatw
force-pushed
the
uiclustername
branch
5 times, most recently
from
79fe559
to
f9a97fd
Compare
rchikatw
force-pushed
the
uiclustername
branch
from
f9a97fd
to
6758d81
Compare
leelavg
reviewed
Oct 11, 2024
...or/github.com/red-hat-storage/ocs-operator/services/provider/api/v4/interfaces/interfaces.go
Outdated
Show resolved
Hide resolved
rchikatw
force-pushed
the
uiclustername
branch
4 times, most recently
from
98a75ad
to
e159cf2
Compare
|
LGTM. will wait for other review. |
rohan47
reviewed
Oct 14, 2024
nb-ohad
requested changes
Oct 14, 2024
rchikatw
force-pushed
the
uiclustername
branch
3 times, most recently
from
d7a9a09
to
0ea8e43
Compare
rchikatw
force-pushed
the
uiclustername
branch
4 times, most recently
from
36c4de6
to
fc833d1
Compare
rchikatw
changed the title
nb-ohad
requested changes
Oct 21, 2024
Signed-off-by: rchikatw <[email protected]>
rchikatw
force-pushed
the
uiclustername
branch
from
fc833d1
to
fe0a8a4
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nb-ohad, rchikatw The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 64a0317
into
red-hat-storage:main
12 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.