Generates VolRepClasses based on the RamenDR replication schedule resource #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: raaizik The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
raaizik
changed the title
raaizik
force-pushed
the
RHSTOR-5753
branch
2 times, most recently
from
597255c
to
7a6fc7b
Compare
raaizik
force-pushed
the
RHSTOR-5753
branch
2 times, most recently
from
626d539
to
f0ceee7
Compare
raaizik
force-pushed
the
RHSTOR-5753
branch
3 times, most recently
from
08910fd
to
8ee12ce
Compare
raaizik
changed the title
VolRepClass based on the RamenDR replication schedule resource
raaizik
force-pushed
the
RHSTOR-5753
branch
3 times, most recently
from
66dca4f
to
27ee9da
Compare
raaizik
changed the title
VolRepClass based on the RamenDR replication schedule resource
|
Depends on #2727 |
raaizik
force-pushed
the
RHSTOR-5753
branch
2 times, most recently
from
4eb8312
to
0f8ca79
Compare
|
/cc @Madhu-1 |
Madhu-1
reviewed
Nov 12, 2024
go.mod
Outdated
| @@ -19,18 +20,21 @@ exclude ( | |||
|
|
|||
| require ( | |||
| github.com/ceph/ceph-csi-operator/api v0.0.0-20240812072523-4d50cf3a32a0 | |||
| github.com/csi-addons/kubernetes-csi-addons v0.8.0 | |||
| return []reconcile.Request{} | ||
| } | ||
|
|
||
| // Return name and namespace of the StorageClaim object |
There was a problem hiding this comment.
update the comment as there is no namespace as its clusterscoped resouces
Comment on lines
507
to
511
| err = utils.CreateOrReplace(r.ctx, r.Client, volumeReplicationClassFlattenMode, func() error { | ||
| utils.AddLabels(volumeReplicationClassFlattenMode, resource.Labels) | ||
| utils.AddAnnotation(volumeReplicationClassFlattenMode, storageClaimAnnotation, r.storageClaim.Name) | ||
| utils.AddAnnotations(volumeReplicationClassFlattenMode, resource.Annotations) | ||
| volumeReplicationClassFlattenMode.Spec.Parameters = data |
There was a problem hiding this comment.
This class needs a parameters flattenMode, i see we dont have any check to see what parameters need to set, if we VolumeReplicationClass we are just going and creating 2 classes. one should have flattenMode set to never and another one should have flattenMode set to force
raaizik
force-pushed
the
RHSTOR-5753
branch
8 times, most recently
from
551ad68
to
3c18bf7
Compare
|
Testing: @Madhu-1 could you verify that vrc has the right parameters/labels/annotations? |
|
@rewantsoni parameters looks good, am not sure about the annotations/labels |
rewantsoni
suggested changes
Nov 13, 2024
| @@ -424,6 +469,44 @@ func (r *StorageClaimReconciler) reconcilePhases() (reconcile.Result, error) { | |||
| if err != nil { | |||
| return reconcile.Result{}, fmt.Errorf("failed to create or update VolumeSnapshotClass: %s", err) | |||
| } | |||
| case "VolumeReplicationClass": | |||
There was a problem hiding this comment.
What happens when the drClusterConfig is deleted? Will the VRC's get deleted as well?
raaizik
force-pushed
the
RHSTOR-5753
branch
2 times, most recently
from
a640d1e
to
8de6b52
Compare
Madhu-1
reviewed
Nov 14, 2024
| } | ||
| // check if DRClusterConfig has been removed | ||
| if len(drclusterconfigs.Items) == 0 { | ||
| vrcs := &replicationv1alpha1.VolumeReplicationClassList{} |
There was a problem hiding this comment.
just set the owneRef of VolumeReplicationClass as the drclusterconfig as both are clusterscoped resouces?
| } | ||
| } | ||
| drclusterconfig := &drclusterconfigs.Items[0] | ||
| for interval := range drclusterconfig.Spec.ReplicationSchedules { |
There was a problem hiding this comment.
what will happen when specific ReplicationSchedules are deleted?
There was a problem hiding this comment.
Missed that, added ✔️
- Creates VolRepClass in response to changes made to DRClusterConfig - k8s csi addons bump Signed-off-by: raaizik <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changess
VolumeReplicationClassin response to changes made toDRClusterConfig-- the RamenDR replication schedule CR. VRCs are generated per each sched interval detailed inDRClusterConfig, for both flatten and non-flatten mode VRC types.RHSTOR-5753