csi: enable csi-omap based on key in operator config #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leelavg
reviewed
Mar 11, 2024
|
pls rebase, it's a bit confusing to review in current state, thanks. |
leelavg
reviewed
Apr 29, 2024
rewantsoni
force-pushed
the
csi-omap
branch
from
5dced9d
to
e7891c5
Compare
Madhu-1
reviewed
Nov 5, 2024
Madhu-1
reviewed
Nov 5, 2024
rewantsoni
force-pushed
the
csi-omap
branch
2 times, most recently
from
bc255a4
to
3d787c1
Compare
|
LGTM |
rewantsoni
changed the title
rewantsoni
force-pushed
the
csi-omap
branch
2 times, most recently
from
f05f083
to
8a8f141
Compare
nb-ohad
requested changes
Nov 14, 2024
rewantsoni
force-pushed
the
csi-omap
branch
3 times, most recently
from
5f697a8
to
0702bce
Compare
Signed-off-by: Rewant Soni <[email protected]>
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nb-ohad, rewantsoni The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 7d92043
into
red-hat-storage:main
10 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The csi-omap generator needs to the enabled on the application cluster for RDR.
Add a new key to operator configMap controller to enable omap. If the key is not set we will always enable this option on operator Config CR. If key is available we will set the value to what was provider in
ocs-client-operator-config