Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase catalog source wait timeout to 15 minutes #1044

Closed
wants to merge 1 commit into from

Conversation

obnoxxx
Copy link
Contributor

@obnoxxx obnoxxx commented Nov 22, 2019

Based on the discussion in https://bugzilla.redhat.com/show_bug.cgi?id=1770192

8 minutes may not be enough. According to this:

operator-framework/operator-lifecycle-manager#947
operator-framework/operator-lifecycle-manager#1098
operator-framework/operator-lifecycle-manager#974
https://bugzilla.redhat.com/show_bug.cgi?id=1737081

More than 10 minutes have been seen.
Trying 15 minutes. We may need even more?

Signed-off-by: Michael Adam [email protected]

@obnoxxx obnoxxx requested a review from a team as a code owner November 22, 2019 15:41
@RazTamir
Copy link
Contributor

Actually it will now wait for 1 hour (900 * 4) because of this decorator
@Retry(ResourceInUnexpectedState, tries=4, delay=5, backoff=1)

Which have 4 retries

@vasukulkarni
Copy link
Contributor

Dont think we need this one then?

@clacroix12
Copy link
Contributor

If we do need to wait for longer I suggest we simply increase the retry count instead of changing the duration we wait for.

@obnoxxx
Copy link
Contributor Author

obnoxxx commented Nov 25, 2019

sure

@obnoxxx obnoxxx closed this Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants