BUG 2264900: rbd: add ParentInTrash parameter in rbdImage struct #298
Conversation
|
@Rakshith-R: This pull request references Bugzilla bug 2264900, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@openshift-ci[bot]: GitHub didn't allow me to request PR reviews from the following users: keesturam. Note that only red-hat-storage members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cc @red-hat-storage/ceph-csi-admins |
|
/hold |
|
ceph#4522 contains 2 commits, but here i can see only 1 |
Rakshith-R
force-pushed
the
BZ-snap-dead
branch
from
c7f19a2
to
6faf48e
Compare
This commit adds ParentInTrash parameter in rbdImage struct and makes use of it in getParent() function in order to avoid error in case the parent is present but in trash. Signed-off-by: Rakshith R <[email protected]> (cherry picked from commit c34b31e)
Rakshith-R
force-pushed
the
BZ-snap-dead
branch
from
6faf48e
to
50639b9
Compare
I didn't backpprt the e2e commit since we don't run it downstream. |
Even though we don't but we need to keep it in sync as it was part of the PR. |
I don't see a point in that, we have previously cherry picked particular commits only from a pr, even though the commits were added with various other miscellaneous changes in the original pr. |
This commit modifies a test case to check creation of PVC-PVC clone of a restored PVC when parent snapshot is deleted. Signed-off-by: Rakshith R <[email protected]> (cherry picked from commit 1bb78fd)
Rakshith-R
force-pushed
the
BZ-snap-dead
branch
from
1b5b05f
to
c329481
Compare
that can be done if the changes are completely different not related to each other, The PR had 2 commits one for code changes and one for E2E for such cases it need to be insync. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: iPraveenParihar, Madhu-1, Rakshith-R The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 5400d8a
into
red-hat-storage:release-4.16
|
@Rakshith-R: All pull requests linked via external trackers have merged: Bugzilla bug 2264900 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This commit adds ParentInTrash parameter in rbdImage struct and makes use of it in getParent() function in order to avoid error in case the parent is present but in trash.
Signed-off-by: Rakshith R [email protected]
(cherry picked from commit c34b31e)