Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG 2138155: fix namespace name update in metadata and rados object #144

Merged

Conversation

Madhu-1
Copy link
Member

@Madhu-1 Madhu-1 commented Oct 31, 2022

Backport of ceph#3477 to fix metadata reattach issue.

If a PV is reattached to a new PVC in a different
namespace we need to update the namespace name
in the rbd image metadata.

Signed-off-by: Madhu Rajanna <[email protected]>
(cherry picked from commit 019628c)
If a PV is reattached to a new PVC in a different
namespace we need to update the namespace name
in the rados object.

Signed-off-by: Madhu Rajanna <[email protected]>
(cherry picked from commit 07aa9de)
Added E2E test case to verify metadata after
PV is attached to a new PVC in different namespace.

Signed-off-by: Madhu Rajanna <[email protected]>
(cherry picked from commit 0530134)
@openshift-ci
Copy link

openshift-ci bot commented Oct 31, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Madhu-1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link

openshift-ci bot commented Oct 31, 2022

@Madhu-1: This pull request references Bugzilla bug 2138155, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (ODF 4.12.0) matches configured target release for branch (ODF 4.12.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla ([email protected]), skipping review request.

In response to this:

BUG 2138155: fix namespace name update in metadata and rados object

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Madhu-1
Copy link
Member Author

Madhu-1 commented Oct 31, 2022

/assign @agarwal-mudit

@agarwal-mudit
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Code looks good label Oct 31, 2022
@openshift-merge-robot openshift-merge-robot merged commit 086ee47 into red-hat-storage:release-4.12 Oct 31, 2022
@openshift-ci
Copy link

openshift-ci bot commented Oct 31, 2022

@Madhu-1: All pull requests linked via external trackers have merged:

Bugzilla bug 2138155 has been moved to the MODIFIED state.

In response to this:

BUG 2138155: fix namespace name update in metadata and rados object

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants