Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sync] feat: add predicates on deployment (#1172) #336

Merged

Conversation

zdtsw
Copy link

@zdtsw zdtsw commented Aug 29, 2024

Description

  • update: logic for manage resource with skip unnecessary reconcile
  • add predicate.Funcs for deployments to reduce reconciles on all components

Signed-off-by: Wen Zhou [email protected]


Signed-off-by: Wen Zhou [email protected]
(cherry picked from commit 6f82d01)

How Has This Been Tested?

Screenshot or short clip

Merge criteria

  • You have read the contributors guide.
  • Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
  • Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Copy link

@VaishnaviHire VaishnaviHire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Aug 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: VaishnaviHire, zdtsw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [VaishnaviHire,zdtsw]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

* update: logic for manage resource with skip unnecessary reconcile

- add predicate.Funcs for deployments to reduce reconciles on all components

Signed-off-by: Wen Zhou <[email protected]>

---------

Signed-off-by: Wen Zhou <[email protected]>
(cherry picked from commit 6f82d01)
Signed-off-by: Wen Zhou <[email protected]>
Copy link

openshift-ci bot commented Aug 30, 2024

New changes are detected. LGTM label has been removed.

@zdtsw zdtsw merged commit 1ab49fc into red-hat-data-services:main Aug 30, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants