Skip to content

Commit

Permalink
chore: fix remove trailing slash from GITHUB_URL (opendatahub-io#1060)
Browse files Browse the repository at this point in the history
The GITHUB_URL was set to https://github.com/ (note the trailing slash)
which causes the script to fail in certain environment where git is
configured to rewrite the url i.e. to always use the ssh protocol:

  [url "[email protected]:"]
    insteadOf = https://github.com

Signed-off-by: Luca Burgazzoli <[email protected]>
  • Loading branch information
lburgazzoli authored Jun 15, 2024
1 parent 1b04761 commit 96f453f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion get_all_manifests.sh
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#!/bin/bash
set -e

GITHUB_URL="https://github.com/"
GITHUB_URL="https://github.com"

# component: notebook, dsp, kserve, dashbaord, cf/ray/kueue/trainingoperator, trustyai, modelmesh, modelregistry.
# in the format of "repo-org:repo-name:branch-name:source-folder:target-folder".
Expand Down

0 comments on commit 96f453f

Please sign in to comment.