Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: patch the images only on the odh-notebook-controller #35

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 0 additions & 22 deletions components/base/kustomization.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,25 +4,3 @@ kind: Kustomization
bases:
- ../notebook-controller/config/overlays/openshift
- ../odh-notebook-controller/config/base

configMapGenerator:
- name: notebook-controller-image-parameters
env: params.env
generatorOptions:
disableNameSuffixHash: true

vars:
- name: odh-kf-notebook-controller-image
objref:
kind: ConfigMap
name: notebook-controller-image-parameters
apiVersion: v1
fieldref:
fieldpath: data.odh-kf-notebook-controller-image
- name: odh-notebook-controller-image
objref:
kind: ConfigMap
name: notebook-controller-image-parameters
apiVersion: v1
fieldref:
fieldpath: data.odh-notebook-controller-image
Original file line number Diff line number Diff line change
Expand Up @@ -22,3 +22,12 @@ patchesStrategicMerge:
- remove_namespace_patch.yaml
- manager_openshift_patch.yaml
- manager_service_openshift_patch.yaml

vars:
- name: odh-kf-notebook-controller-image
objref:
kind: ConfigMap
name: notebook-controller-image-parameters
apiVersion: v1
fieldref:
fieldpath: data.odh-kf-notebook-controller-image
15 changes: 15 additions & 0 deletions components/odh-notebook-controller/config/base/kustomization.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,18 @@ apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization
resources:
- ../default

configMapGenerator:
- name: notebook-controller-image-parameters
env: params.env
generatorOptions:
disableNameSuffixHash: true

vars:
- name: odh-notebook-controller-image
objref:
kind: ConfigMap
name: notebook-controller-image-parameters
apiVersion: v1
fieldref:
fieldpath: data.odh-notebook-controller-image
Loading