Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bar_plot log with log parameter #110

Merged
merged 3 commits into from
May 25, 2024
Merged

Fix bar_plot log with log parameter #110

merged 3 commits into from
May 25, 2024

Conversation

mrkn
Copy link
Member

@mrkn mrkn commented May 24, 2024

Fixes the following error.

Failure: test_bar_plot_log[adapter: :array, backend: :plotly](PlotMethodsBarPlotTest::rendering):
  Exception raised:
  ArgumentError(<comparison of Array with Array failed>)
  /Users/mrkn/src/github.com/red-data-tools/charty/lib/charty/plotters/bar_plotter.rb:97:in `min'
  /Users/mrkn/src/github.com/red-data-tools/charty/lib/charty/plotters/bar_plotter.rb:97:in `annotate_axes'
  /Users/mrkn/src/github.com/red-data-tools/charty/lib/charty/plotters/bar_plotter.rb:53:in `render_plot'
  /Users/mrkn/src/github.com/red-data-tools/charty/lib/charty/plotters/abstract_plotter.rb:260:in `call_render_plot'
  /Users/mrkn/src/github.com/red-data-tools/charty/lib/charty/plotters/abstract_plotter.rb:254:in `render'
  /Users/mrkn/src/github.com/red-data-tools/charty/test/helper.rb:212:in `render_plot'
  /Users/mrkn/src/github.com/red-data-tools/charty/test/plot_methods/bar_plot_test.rb:236:in `block in test_bar_plot_log'

@kou kou merged commit cf1295d into master May 25, 2024
20 of 22 checks passed
@kou kou deleted the fix_bar_plot_log branch May 25, 2024 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants