Add Custom Fields on Adjustments #740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
recurly-integrations
force-pushed
the
den_165_cf_on_charges
branch
from
4b430d1 to
616b326
Compare
mwlang
approved these changes
Jan 20, 2023
douglaslise
reviewed
Jan 20, 2023
| @@ -58,6 +58,12 @@ Location: https://api.recurly.com/v2/invoices | |||
| <created_at nil="nil"></created_at> | |||
| <updated_at nil="nil"></updated_at> | |||
| <revenue_schedule_type>at_invoice</revenue_schedule_type> | |||
| <custom_fields> | |||
douglaslise
reviewed
Jan 20, 2023
| @@ -12,6 +12,12 @@ Content-Type: application/xml; charset=utf-8 | |||
| <description>$12 Annual Subscription</description> | |||
| <accounting_code></accounting_code> | |||
| <product_code nil="nil"></product_code> | |||
| <custom_fields> | |||
There was a problem hiding this comment.
In some cases (it happens for ruby) when the element does not have the type=array then it is not parsed as an array, but as a single element. So I suggest to add the type to comply with the actual response:
Suggested change
| <custom_fields> | |
| <custom_fields type="array"> |
douglaslise
approved these changes
Jan 23, 2023
recurly-integrations
pushed a commit
that referenced
this pull request
Feb 6, 2023
[Full Changelog](2.12.36...2.12.37) **Merged Pull Requests** - Add Custom Fields on Adjustments [#740](#740) ([ngleiser](https://github.com/ngleiser)) - Added decline code to transaction error [#737](#737) ([arzitney](https://github.com/arzitney))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for custom fields on adjustments