Fixing casting for list types that are not in pagers #539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joannasese
reviewed
Sep 17, 2020
| $item_class = static::hintArrayType($setter); | ||
| if (!preg_match('/^Recurly/', $item_class)) { | ||
| if (!preg_match('/^\\\Recurly/', $item_class)) { |
There was a problem hiding this comment.
So basically it's changing from Recurly to \Recurly?
There was a problem hiding this comment.
Yes, that's what is happening here. This bit of code has actually never been run before. It always should have been \Recurly
douglasmiller
added a commit
that referenced
this pull request
Sep 22, 2020
# Changelog ## [Unreleased](https://github.com/recurly/recurly-client-php/tree/HEAD) [Full Changelog](3.7.0...HEAD) **Implemented enhancements:** - Latest Changes for 2019-10-10 [\#541](#541) ([douglasmiller](https://github.com/douglasmiller)) - Latest Changes for 2019-10-10 \(Automated Exports, additional resource data methods\) [\#537](#537) ([douglasmiller](https://github.com/douglasmiller)) **Fixed bugs:** - Fixing casting for list types that are not in pagers [\#539](#539) ([douglasmiller](https://github.com/douglasmiller))
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug with casting responses with array values that do not contain the
objectkey. This functionality has not been encountered previously as all current arrays have contained resources with theobjectkey.