Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[V3] Mock Client #461

Merged
merged 10 commits into from
Feb 21, 2020
Merged

[V3] Mock Client #461

merged 10 commits into from
Feb 21, 2020

Conversation

bhelx
Copy link
Contributor

@bhelx bhelx commented Feb 19, 2020 •
edited
Loading

Creating a MockClient for use in testing. Trying to get better coverage of the BaseClient.

@bhelx bhelx requested a review from douglasmiller February 19, 2020 18:22
@guardrails
Copy link

guardrails bot commented Feb 19, 2020 •
edited
Loading

⚠️ We detected security issues in this pull request:

Insecure File Management (1)

recurly-client-php/lib/recurly/http_adapter.php

Line 42 in 959ccd0

$result = file_get_contents($url, false, $context);

More info on how to fix Insecure File Management in PHP.

👉 Go to the dashboard for detailed results.

📥 Happy? Share your feedback with us.

@bhelx bhelx marked this pull request as ready for review February 21, 2020 19:52
bhelx
bhelx commented Feb 21, 2020
View reviewed changes
lib/recurly/http_adapter.php Outdated Show resolved Hide resolved
@douglasmiller douglasmiller merged commit eec31fc into v3 Feb 21, 2020
@bhelx bhelx deleted the v3-mock-client branch February 21, 2020 23:02
@joannasese joannasese added the V3 v2019-10-10 Client label Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@douglasmiller douglasmiller douglasmiller left review comments

Assignees
No one assigned
Labels
V3 v2019-10-10 Client
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bhelx @douglasmiller @joannasese