fix specs

recurly · Feb 19, 2024 · c000474 · c000474
1 parent aadbc64
commit c000474
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 8 deletions.
diff --git a/Tests/Recurly/GiftCard_Test.php b/Tests/Recurly/GiftCard_Test.php
@@ -19,14 +19,14 @@ public function testGetGiftCard() {
     $this->assertEquals($giftCard->product_code,'gift_card');
     $this->assertEquals($giftCard->unit_amount_in_cents,'2000');
     $this->assertEquals($giftCard->currency,'USD');
-    $this->assertEquals($giftCard->redeemed_at,'2011-04-25T07:00:00Z');
-    $this->assertEquals($giftCard->delivered_at,'2011-04-25T07:00:00Z');
     $this->assertEquals($giftCard->balance_in_cents,'2000');
-    $this->assertEquals($giftCard->created_at,'2011-04-25T07:00:00Z');
-    $this->assertEquals($giftCard->updated_at,'2011-04-25T07:00:00Z');
     $this->assertEquals($giftCard->liability_gl_account_id,'t5ejtge1xw0x');
     $this->assertEquals($giftCard->revenue_gl_account_id,'t5ejtgf1vxh1');
     $this->assertEquals($giftCard->performance_obligation_id,'4');
+    $this->assertInstanceOf('DateTime', $giftCard->created_at);
+    $this->assertInstanceOf('DateTime', $giftCard->updated_at);
+    $this->assertInstanceOf('DateTime', $giftCard->redeemed_at);
+    $this->assertInstanceOf('DateTime', $giftCard->delivered_at);
   }
 
   public function testRedeemGiftCard() {

diff --git a/Tests/Recurly/Item_Test.php b/Tests/Recurly/Item_Test.php
@@ -61,7 +61,7 @@ public function testReactivate() {
     $this->assertEquals('active', $item->state);
     $this->assertEquals($item->liability_gl_account_id,'t5ejtge1xw0x');
     $this->assertEquals($item->revenue_gl_account_id,'t5ejtgf1vxh1');
-    $this->assertEquals($item->performance_obligation_id,'4');
+    $this->assertEquals($item->performance_obligation_id,'5');
   }
 
   public function testReactivateItem() {
@@ -72,7 +72,7 @@ public function testReactivateItem() {
     $this->assertEquals('active', $item->state);
     $this->assertEquals($item->liability_gl_account_id,'t5ejtge1xw0x');
     $this->assertEquals($item->revenue_gl_account_id,'t5ejtgf1vxh1');
-    $this->assertEquals($item->performance_obligation_id,'4');
+    $this->assertEquals($item->performance_obligation_id,'5');
   }
 
   public function testCreateXml() {
@@ -83,7 +83,7 @@ public function testCreateXml() {
     $item->custom_fields[] = new Recurly_CustomField('size', 'small');
     $item->liability_gl_account_id = 't5ejtge1xw0x';
     $item->revenue_gl_account_id = 't5ejtgf1vxh1';
-    $item->performance_obligation_id = '4';
+    $item->performance_obligation_id = '5';
 
     $this->assertEquals(
       "<?xml version=\"1.0\" encoding=\"utf-8\"?>\n<item><item_code>little_llama</item_code><name>Little Llama</name><description>A description about llamas</description><custom_fields><custom_field><name>size</name><value>small</value></custom_field></custom_fields><liability_gl_account_id>t5ejtge1xw0x</liability_gl_account_id><revenue_gl_account_id>t5ejtgf1vxh1</revenue_gl_account_id><performance_obligation_id>5</performance_obligation_id></item>\n",

diff --git a/lib/recurly/item.php b/lib/recurly/item.php
@@ -74,7 +74,8 @@ protected function getNodeName() {
   protected function getWriteableAttributes() {
     return array(
       'item_code', 'name', 'description', 'external_sku', 
-      'accounting_code', 'revenue', 'state', 'custom_fields'
+      'accounting_code', 'revenue', 'state', 'custom_fields',
+      'liability_gl_account_id', 'revenue_gl_account_id', 'performance_obligation_id'
     );
   }
 }