Adds jest and @testing-library/react #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
babel.config.js
Outdated
| 'plugins': [ | ||
| 'transform-class-properties' | ||
| ] | ||
| } |
There was a problem hiding this comment.
nit: indentation is a bit wonky and missing semicolon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple notes
-Separated out the demo into two files,
app.jsandindex.js. ReactDOM'srenderoperation throws an error when jest runs testing, asdocument.querySelector('.App')returns null in that env. It sounds like we're not going to use the demo for testing, so I can separate that into its own commit so it can be easily reverted if necessary.-Had to change
.babelrcto usebabel.config.js, as we're importing recurly.js from node_modules injest.setup.js, and it must be transpiled (jestjs/jest#8365)