Updates for PHPStan 2.0 #48

carlos-granados · 2024-11-15T12:05:13Z

Updates needed to update this to run with PHPStan 2.0

To install locally I had to remove the references to rector/rector and symplify/phpstan-extensions in composer.json. This should be updated once these dependencies are updated

carlos-granados · 2024-11-15T12:07:20Z

src/Matcher/ClassMethodCallReferenceResolver.php

@@ -40,12 +40,12 @@ public function resolve(MethodCall|MethodCallableNode $methodCallOrMethodCallabl
            return null;
        }

-        if (! $callerType instanceof TypeWithClassName) {
+        if (count($callerType->getObjectClassNames()) !== 1) {


See https://phpstan.org/blog/why-is-instanceof-type-wrong-and-getting-deprecated

carlos-granados · 2024-11-15T12:08:03Z

src/Printer/CollectorMetadataPrinter.php

@@ -13,7 +13,7 @@
 use PhpParser\Node\NullableType;
 use PhpParser\Node\Stmt\ClassMethod;
 use PhpParser\Node\UnionType;
-use PhpParser\PrettyPrinter\Standard;
+use PHPStan\Node\Printer\Printer;


PHPStan has removed the PhpParser\PrettyPrinter\Standard alias and now we need to use PHPStan\Node\Printer\Printer directly

carlos-granados · 2024-11-15T12:08:38Z

src/Printer/CollectorMetadataPrinter.php

-    {
-        $this->printerStandard = new Standard();
+    public function __construct(
+        private Printer $printer


PHPStan complains if we try to instantiate this directly, it needs to be passed through dependency injection

Feel free to create new Standard printer directly, as we lightweight. We don't need any special printer here

carlos-granados · 2024-11-15T12:09:31Z

src/Printer/CollectorMetadataPrinter.php

@@ -56,6 +54,7 @@ public function printArgTypesAsString(MethodCall $methodCall, ExtendedMethodRefl
                return ResolvedTypes::UNKNOWN_TYPES;
            }

+            // @phpstan-ignore phpstanApi.instanceofType


In this case there is no good alternative to checking that it is an instance of IntersectionType (at least I was not able to find one), so I have added a ignore comment

Better place it in phpstan.neon, so we have all ignores in one place.

carlos-granados · 2024-11-15T12:09:49Z

src/Printer/CollectorMetadataPrinter.php

@@ -160,15 +159,15 @@ private function resolveSortedTypes(UnionType|NodeIntersectionType $paramType, ?

    private function printTypeToString(Type $type): string
    {
-        if ($type instanceof ClassStringType) {
+        if ($type->isClassString()->yes()) {


PHPStan recommends using these alternatives

carlos-granados · 2024-11-15T12:11:00Z

src/Reflection/ReflectionParser.php

@@ -26,7 +27,7 @@ final class ReflectionParser
    public function __construct()
    {
        $parserFactory = new ParserFactory();
-        $this->parser = $parserFactory->create(ParserFactory::PREFER_PHP7);
+        $this->parser = $parserFactory->createForVersion(PhpVersion::fromString('7.4'));


PHPParser 5 has removed the create method. I used the createForVersion instead, setting this as 7.4. I am not really sure that this is the right solution

I think there is some createForLatestPhp(), that should be used instead so we don't create fixed value here

createForNewestSupportedVersion() should work, there is rule for that

https://github.com/rectorphp/rector-php-parser/blob/9639ef9429f74c14fdc3c7dad9d3b0d916663de0/src/Rector/MethodCall/ParserFactoryRector.php#L24-L48

carlos-granados · 2024-11-15T12:11:17Z

src/Rules/NarrowPrivateClassMethodParamTypeRule.php

@@ -110,10 +110,6 @@ private function validateArgVsParamTypes(array $args, MethodCall $methodCall, Sc
                continue;
            }

-            if (! $arg instanceof Arg) {


$arg will always be an Arg, this check is not needed

carlos-granados · 2024-11-15T12:11:53Z

src/Rules/NoArrayAccessOnObjectRule.php

@@ -43,6 +43,7 @@ public function getNodeType(): string
    public function processNode(Node $node, Scope $scope): array
    {
        $varType = $scope->getType($node->var);
+        // @phpstan-ignore phpstanApi.instanceofType


Again, there is no good alternative or at least I was not able to find one

carlos-granados · 2024-11-15T12:12:26Z

src/Rules/NoParamTypeRemovalRule.php

@@ -55,6 +55,7 @@ public function processNode(Node $node, Scope $scope): array
        }

        $parentClassMethodReflection = $this->methodNodeAnalyser->matchFirstParentClassMethod($scope, $classMethodName);
+        // @phpstan-ignore phpstanApi.instanceofAssumption


This is not covered by PHPStan's BC guarantee, for now we ignore it

carlos-granados · 2024-11-15T12:12:53Z

tests/Rules/NarrowPrivateClassMethodParamTypeRule/NarrowPrivateClassMethodParamTypeRuleTest.php

@@ -16,7 +16,7 @@
 final class NarrowPrivateClassMethodParamTypeRuleTest extends RuleTestCase
 {
    /**
-     * @param mixed[] $expectedErrorsWithLines
+     * @param list<array{0: string, 1: int, 2?: string|null}> $expectedErrorsWithLines


PHPStan asks us to add a more detailed type hint

carlos-granados · 2024-11-15T13:19:44Z

@TomasVotruba @samsonasik updated

samsonasik · 2024-11-15T14:42:24Z

src/Reflection/ReflectionParser.php

@@ -26,7 +26,7 @@ final class ReflectionParser
    public function __construct()
    {
        $parserFactory = new ParserFactory();
-        $this->parser = $parserFactory->create(ParserFactory::PREFER_PHP7);
+        $this->parser = $parserFactory->createForNewestSupportedVersion();


it needs verify under php 7.x, since rector downgraded to php 7.2, will verify after PR on rector side finished

Upgrade to PHPParser 5 and PHPStan 2 rector-src#6431

currently still wip :)

That's why I said I wasn't sure what to do here and why I initially used createForVersion(PhpVersion::fromString('7.4')) I'll let you decide what really needs to go here.

BTW the new Rector probably needs to downgrade to PHP 7.4 since PHPStan dropped support for 7.2 and 7.3, but again not really sure

I see, Rector require phpstan, so php 7.4 will be minimum then ;)

I tested on rector side, with ->createForNewestSupportedVersion(), it got error on curly array $string{0}

There was 1 error: 1) Rector\Tests\Php74\Rector\ArrayDimFetch\CurlyToSquareBracketArrayStringRector\CurlyToSquareBracketArrayStringRectorTest::test with data set #0 ('/Users/samsonasik/www/rector-...hp.inc') PHPStan\Parser\ParserErrorsException: Syntax error, unexpected '{', expecting ';', Syntax error, unexpected '{', expecting ';', Syntax error, unexpected '{', expecting ';' phar:///Users/samsonasik/www/rector-src/vendor/phpstan/phpstan/phpstan.phar/src/Parser/RichParser.php:70

updating to :

createForVersion(PhpVersion::fromString('7.0'))

make it working:

PHPUnit 10.5.38 by Sebastian Bergmann and contributors. Runtime: PHP 8.3.12 Configuration: /Users/samsonasik/www/rector-src/phpunit.xml . 1 / 1 (100%) Time: 00:00.316, Memory: 62.50 MB OK (1 test, 2 assertions)

see rectorphp/rector-src#6431 (comment)

this needs fallback to php 8.0 tho, I will keep updating ;)

Let me know if I can help in any way

I got it, on rector side, using ->createForNewestSupportedVersion() needs to be on default, then if it catch PHPStan\Parser\ParserErrorsException, fallback to use php 7 parser when doing parsing, see rectorphp/rector-src@3bb03c6

If parsing process doesn't involve phpstan, you may need to use PhpParser\Error for catch and retry with createForVersion(PhpVersion::fromString('7.0')), something like:

try { // parse with newest supported version } catch (\PhpParser\Error) { // parse with php 7 parser }

mitelg · 2024-11-29T12:19:50Z

hey @carlos-granados

thanks for your current work! 💪 we are currently waiting for this extension to be compatible with PHPStan 2, so I want to offer my help 🙂 let me know, if I can somehow support here

carlos-granados · 2024-11-29T12:34:03Z

@mitelg it is all now in the hands of the Rector team. I am guessing that they first want to release Rector 2.0 (which is happening on 12/12) and then they'll look into the other dependencies. You may enquire in this issue rectorphp/rector#8815

samsonasik · 2024-12-12T10:36:14Z

I cherry-picked your commits at PR:

Bump to phpstan-extension 12.0 #49

to continue work on it.

TomasVotruba · 2024-12-12T10:38:12Z

Cherry picked in #49,

Thank you 🙏

Updates for PHPStan 2.0

4df6e0b

carlos-granados commented Nov 15, 2024

View reviewed changes

carlos-granados mentioned this pull request Nov 15, 2024

Get ready for PHPStan 2.0 rectorphp/rector#8815

Closed

Changes after PR review

9818b42

samsonasik reviewed Nov 15, 2024

View reviewed changes

TomasVotruba closed this Dec 12, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updates for PHPStan 2.0 #48

Updates for PHPStan 2.0 #48

carlos-granados commented Nov 15, 2024 •

edited

Loading

carlos-granados Nov 15, 2024

carlos-granados Nov 15, 2024

carlos-granados Nov 15, 2024

TomasVotruba Nov 15, 2024

carlos-granados Nov 15, 2024

TomasVotruba Nov 15, 2024

carlos-granados Nov 15, 2024

carlos-granados Nov 15, 2024

TomasVotruba Nov 15, 2024

samsonasik Nov 15, 2024

carlos-granados Nov 15, 2024

carlos-granados Nov 15, 2024

carlos-granados Nov 15, 2024

carlos-granados Nov 15, 2024

carlos-granados commented Nov 15, 2024

samsonasik Nov 15, 2024

carlos-granados Nov 15, 2024

samsonasik Nov 15, 2024

samsonasik Nov 16, 2024

carlos-granados Nov 16, 2024 •

edited

Loading

samsonasik Nov 17, 2024 •

edited

Loading

mitelg commented Nov 29, 2024

carlos-granados commented Nov 29, 2024

samsonasik commented Dec 12, 2024

TomasVotruba commented Dec 12, 2024

Updates for PHPStan 2.0 #48

Updates for PHPStan 2.0 #48

Conversation

carlos-granados commented Nov 15, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

carlos-granados commented Nov 15, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

carlos-granados Nov 16, 2024 • edited Loading

Choose a reason for hiding this comment

samsonasik Nov 17, 2024 • edited Loading

Choose a reason for hiding this comment

mitelg commented Nov 29, 2024

carlos-granados commented Nov 29, 2024

samsonasik commented Dec 12, 2024

TomasVotruba commented Dec 12, 2024

carlos-granados commented Nov 15, 2024 •

edited

Loading

carlos-granados Nov 16, 2024 •

edited

Loading

samsonasik Nov 17, 2024 •

edited

Loading