[Privatization] Skip ChangeReadOnlyPropertyWithDefaultValueToConstantRector on call reference by another class #6234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Rector on call reference by another class
|
All checks have passed 🎉 @TomasVotruba it is ready for review. |
|
Temporary closing it as the issue happen for |
TomasVotruba
added a commit
that referenced
this pull request
Aug 22, 2024
rectorphp/rector-src@8aaee5e [Performance] Cache should traverse for AddUseStatementGuard (#6234)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@zingimmick this already handled, just can't be detected by
NodeRepositoryas it was placed inSourcedirectory, even registered in composer.json autoload-dev.The "another class" call with reference moved to fixture class itself solve it.
Closes #6214