Refactor AnnotationExtractor fomr FileDiff value object to standalone RectorsChangelogResolver service #6088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomasVotruba
force-pushed
the
improve-annot-resolver
branch
2 times, most recently
from
7633ccf to
ab6b960
Compare
TomasVotruba
changed the title
TomasVotruba
force-pushed
the
improve-annot-resolver
branch
2 times, most recently
from
fee55a9 to
2d9442b
Compare
… RectorsChangelogResolver service
TomasVotruba
force-pushed
the
improve-annot-resolver
branch
from
2d9442b to
5fa7e15
Compare
TomasVotruba
added a commit
that referenced
this pull request
Jun 30, 2024
rectorphp/rector-src@9fa1da9 Add few union type fixtures to ReturnTypeFromStrictTypedCallRector (#6088)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small follow up to #6073
Looking at it closre, the
FileDiffshould be only dummy value object not knowing about formatters and output. This should separate the annotation logic out to a service