Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename phpunit.xml to phpunit.xml.dist #5785

Closed
wants to merge 1 commit into from

Conversation

mpdude
Copy link
Contributor

@mpdude mpdude commented Mar 6, 2021

To my knowledge, it is an established practice to name the PHPUnit configuration file phpunit.xml.dist, so that a per-developer configuration can override it in phpunit.xml.

@TomasVotruba
Copy link
Member

It's optional naming, I would like to keep it simple instead of disting everything that can.

What do you need override for?

@mpdude
Copy link
Contributor Author

mpdude commented Mar 6, 2021

Had to make changes while #5784 was in a preliminary state...

I mean the .dist practice is there for a reason, isn't it? At least 90% of the projects I know or work with follow it, so... 🤷🏻

@TomasVotruba
Copy link
Member

If there is no reason to add, there is no need to add extra complexity.

@mpdude mpdude deleted the phpunit-dist branch March 6, 2021 20:47
TomasVotruba added a commit that referenced this pull request Mar 31, 2024
rectorphp/rector-src@d869306 [TypeDeclaration] Handle in inner function on ReturnTypeFromStrictTernaryRector (#5785)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants