Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Symfony 5.2] Add FormBuilderSetDataMapperRector #5339

Merged
merged 15 commits into from
Jan 28, 2021
Merged

[Symfony 5.2] Add FormBuilderSetDataMapperRector #5339

merged 15 commits into from
Jan 28, 2021

Conversation

samsonasik
Copy link
Member

part of #4824

@samsonasik samsonasik changed the title [Symfony 5.2][WIP] Add BuilderSetDataMapperRector [Symfony 5.2][WIP] Add FormBuilderSetDataMapperRector Jan 28, 2021
@samsonasik samsonasik changed the title [Symfony 5.2][WIP] Add FormBuilderSetDataMapperRector [Symfony 5.2] Add FormBuilderSetDataMapperRector Jan 28, 2021
@samsonasik samsonasik closed this Jan 28, 2021
@samsonasik samsonasik reopened this Jan 28, 2021
@samsonasik samsonasik closed this Jan 28, 2021
@samsonasik samsonasik reopened this Jan 28, 2021
@samsonasik
Copy link
Member Author

samsonasik commented Jan 28, 2021 •
edited
Loading

@TomasVotruba it seems there is new phpstan release that make the following error in tests:

1) Rector\CodeQuality\Tests\Rector\Class_\CompleteDynamicPropertiesRector\CompleteDynamicPropertiesRectorTest::test with data set #7 (Symplify\SmartFileSystem\SmartFileInfo Object (...))
Error: Class 'ReflectionUnionType' not found

phar:///home/runner/work/rector/rector/vendor/phpstan/phpstan/phpstan.phar/vendor/ondrejmirtes/better-reflection/src/Reflection/Adapter/ReflectionUnionType.php:9
phar:///home/runner/work/rector/rector/vendor/phpstan/phpstan/phpstan.phar/vendor/ondrejmirtes/better-reflection/src/Reflection/Adapter/ReflectionType.php:27
phar:///home/runner/work/rector/rector/vendor/phpstan/phpstan/phpstan.phar/vendor/ondrejmirtes/better-reflection/src/Reflection/Adapter/ReflectionParameter.php:176

and phpstan error:

WARNING] Internal error: Internal error: Internal error. in file              
           /home/runner/work/rector/rector/rules/php80/src/MatchAndRefactor/StrS
           tartsWithMatchAndRefactor/AbstractMatchAndRefactor.php               
           Run PHPStan with --debug option and post the stack trace to:         
           https://github.com/phpstan/phpstan/issues/new?template=Bug_report.md

https://github.com/phpstan/phpstan/releases/tag/0.12.70

@samsonasik
Copy link
Member Author

The error is only happen in php 7.4 https://github.com/rectorphp/rector/pull/5339/checks?check_run_id=1782400087#step:6:93

@samsonasik
Copy link
Member Author

@TomasVotruba using exact phpstan version 0.12.69 seems fixed the error in php 7.4 6003afb .

All checks have passed 🎉 @TomasVotruba it is ready for review.

@samsonasik samsonasik force-pushed the symfony52-property-path-accessor branch from 916dad2 to 6003afb Compare January 28, 2021 08:25
@samsonasik samsonasik mentioned this pull request Jan 28, 2021
Merged
@TomasVotruba
Copy link
Member

I got same problem with phpstan here in Symplify: https://github.com/symplify/symplify/pull/2876/files/32c7349c840919157c3ad848e6cdb36a1c2de441#diff-d2ab9925cad7eac58e0ff4cc0d251a937ecf49e4b6bf57f8b95aab76648a9d34

It's related to NoParentMethodCallOnEmptyStatementInParentMethodRule that analyses abstract classes, but I could not figure out the workaround

@TomasVotruba TomasVotruba merged commit a54819a into master Jan 28, 2021
@TomasVotruba TomasVotruba deleted the symfony52-property-path-accessor branch January 28, 2021 12:57
@TomasVotruba
Copy link
Member

Thanks 👍

TomasVotruba added a commit that referenced this pull request Dec 8, 2023
@TomasVotruba
Updated Rector to commit 0a2dc3d52b679bad1b07849d951748a8faad7f9a
548d510 
rectorphp/rector-src@0a2dc3d Fix array type if property is used in TypedPropertyFromStrictConstructorRector (#5339)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simivar simivar simivar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@samsonasik @TomasVotruba @simivar