Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Symfony 5.2] Rename setProviderKey()/getProviderKey() to setFirewallName()/getFirewallName() #4888

Merged
merged 2 commits into from
Dec 15, 2020
Merged

[Symfony 5.2] Rename setProviderKey()/getProviderKey() to setFirewallName()/getFirewallName() #4888

merged 2 commits into from
Dec 15, 2020

Conversation

simivar
Copy link
Contributor

@simivar simivar commented Dec 15, 2020

Part of #4824

@simivar simivar requested a review from TomasVotruba December 15, 2020 01:58
@TomasVotruba TomasVotruba merged commit 89e75fe into rectorphp:master Dec 15, 2020
@TomasVotruba
Copy link
Member

TomasVotruba commented Dec 15, 2020

Thank you

Feel free to send multiple PRs at the same time. It's almost always ready to merge so it would be easier to merge them at once :)

@simivar simivar deleted the feature/symfony52-security-firewall-rename branch December 15, 2020 09:17
@simivar
Copy link
Contributor Author

simivar commented Dec 15, 2020

I mostly add them as soon as I have them ready to not get any conflicts. I will try to group them a little to open a few at once :)

@TomasVotruba
Copy link
Member

Adding new rule is usually 100 % isolated from other each other.

In case of buch of rules for single set, I create 5 PRs with each one rule. Then 1 PR that edits the sets.

We merge very quickly, so conflicts usually apear only on PRs that are being worked on for weeks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants