Update to PHP-Parser v4 #330
Conversation
composer.json
Outdated
| "phpdocumentor/reflection-docblock": "^4.3", | ||
| "phpdocumentor/type-resolver": "^0.4", | ||
| "rector/better-reflection": "^3.0.6", | ||
| "roave/better-reflection": "dev-master", |
There was a problem hiding this comment.
Waiting for Roave/BetterReflection#410
There was a problem hiding this comment.
Such PRs could be added here via https://blog.martinhujer.cz/17-tips-for-using-composer-efficiently/#comment-3697775212
There was a problem hiding this comment.
@TomasVotruba Thanks, didn't know that one
|
Horray! Party time :) I'll get to this tomorrow |
carusogabriel
force-pushed
the
php-parser-v4
branch
from
bc8e138 to
6901664
Compare
carusogabriel
force-pushed
the
php-parser-v4
branch
from
6901664 to
59ab1a6
Compare
composer.json
Outdated
| "phpdocumentor/reflection-docblock": "^4.3", | ||
| "phpdocumentor/type-resolver": "^0.4", | ||
| "rector/better-reflection": "^3.0.6", | ||
| "roave/better-reflection": "dev-master#dd2c2d0", |
There was a problem hiding this comment.
To really use stable dependencies, here use rector/better-reflection and update it first to nikic/php-parser 4.0.
I'll release new tag for it then
|
Thank you Gabriel |
|
I'll track Roave/BetterReflection#410, so when that gets merge, we can remove our fork 👍 |
|
Seeing the stuck discussion - though I suggested working solution - it might take many months. All these issues are more relevant: https://github.com/rectorphp/rector/issues |
rectorphp/rector-src@2a394c7 Reflection cleanup + inline union types for couple of param docs (#330)
PHP-Parser v4 was released, and now we can remove our own fork of
Roave/BetterReflection.