Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DX] Forbid @required annotation #5710

Closed
TomasVotruba opened this issue Feb 28, 2021 · 0 comments · Fixed by #5869
Closed

[DX] Forbid @required annotation #5710

TomasVotruba opened this issue Feb 28, 2021 · 0 comments · Fixed by #5869
Labels
feature

Comments

@TomasVotruba
Copy link
Member 

/**
     * @required
     */

❌

It's often miss-used on wrong places.

It happened here too 😆
See https://tomasvotruba.com/blog/2020/06/01/inject-or-required-will-get-you-any-service-fast/
@TomasVotruba TomasVotruba mentioned this issue Mar 16, 2021
Merged
TomasVotruba added a commit that referenced this issue Mar 11, 2024
@TomasVotruba
Updated Rector to commit 8ade0b9e46aff3e6f755a9561579cdc0c9eb9b0e
7660d57 
rectorphp/rector-src@8ade0b9 [EarlyReturn] Clena up equal node check on IfAndAnalyzer::isIfStmtExprUsedInNextReturn() (#5710)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[DX] Forbid @required annotation rectorphp/rector
1 participant
@TomasVotruba